Documentation - progress deadline annotation on per revision basis #5773
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
knative-prow
bot
added
the
size/M
|
Possibly it would be good to include the operator configuration as well. |
There was a problem hiding this comment.
/approve
Probably not a bad idea to include the operator config option here too (that would be a global change, so use a heading like Global (Operator)), the details of how to do so can be found here: https://knative.dev/docs/install/operator/configuring-with-operator/
Note: this will need to be cherry-picked into the current release branch in order to show up on the main site
knative-prow
bot
added
the
approved
There was a problem hiding this comment.
Probably not a bad idea to include the operator config option here too (that would be a global change, so use a heading like Global (Operator)), the details of how to do so can be found here: https://knative.dev/docs/install/operator/configuring-with-operator/
Agreed, if we want to do this, we should have it on all examples or reference the page you linked. I don't think it makes sense to introduce it just here, so
/lgtm
/approve
/cherry-pick release-1.12
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: navinag1989, psschwei, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.12 |
|
@navinag1989: only knative org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.12 |
|
@ReToCode: new pull request created: #5777 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #5767